diffkemp icon indicating copy to clipboard operation
diffkemp copied to clipboard

Missing pip requirement in RPM package

Open PLukas2018 opened this issue 9 months ago • 1 comments

I tried to install DiffKemp on Fedora (in docker) from the RPM package and it looks like that the specification is missing pip as a requirement.

I used the following commands for installation:

dnf install -y dnf-plugins-core
dnf copr enable -y viktormalik/diffkemp
dnf install -y diffkemp

The installation is successful but when I run diffkemp -h error is thrown:

Traceback (most recent call last):
  File "/usr/bin/diffkemp", line 3, in <module>
    from diffkemp import diffkemp
  File "/usr/lib64/python3.11/site-packages/diffkemp/diffkemp.py", line 3, in <module>
    from diffkemp.config import Config
  File "/usr/lib64/python3.11/site-packages/diffkemp/config.py", line 3, in <module>
    from diffkemp.snapshot import Snapshot
  File "/usr/lib64/python3.11/site-packages/diffkemp/snapshot.py", line 14, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

After installing pip with dnf install -y pip it works.

PLukas2018 avatar May 03 '24 09:05 PLukas2018

pkg_resources comes from the setuptools package. I see that we have setuptools in the BuildRequires:

https://github.com/diffkemp/diffkemp/blob/e6cded9aefd2e51ada26c972f499fe08d442d789/rpm/diffkemp.spec#L14

Looks like that it should also be in Requires since it is also a runtime dependency.

FrNecas avatar May 03 '24 11:05 FrNecas

The problem was not encountered when trying it in normal Fedora (not in docker).

PLukas2018 avatar May 15 '24 21:05 PLukas2018