Viktor Malík

Yeah, `offsetof` in kernel requires a type, but for us, supporting expressions is fairly easy. As you noted, it already works with the current approach, so I'd suggest adding tests...

> I do worry about how it scales with modules/complexity of BTF though, a lot of the work is eager/iterates over everything. There may be a future "make all this...

> Okay, how about this: > > 1. Parse kallsyms and keep the module names that symbols come from > 2. When resolving wildcards, resolve against kallsyms, remembering the module,...

Version 2 with several major improvements: - before parsing BTF, collect names of all modules that we're attaching to from `available_filter_functions`, then parse BTF only for those modules (vmlinux BTF...

> I wish there was a nice architectural diagram somewhere that we could change as part of this rework. Oh well. There is a nice picture in [internals_development.md](https://github.com/iovisor/bpftrace/blob/master/docs/internals_development.md), although it...

Thanks for the reviews, let's not prolong this and merge.

`fs/xfs/xfs_linux.h` is an internal kernel header, so bpftrace won't find it. A possible way would be to install the XFS development package (`xfsprogs-devel` on Fedora) and then include `xfs/linux.h` which...

This is a useful feature that would be great to have in bpftrace, so I'm wondering what's the current state. Did the helper ever made it to kernel? Can I...

Hi @BurntBrunch, thanks for opening this! libbpf is currently required for building bpftrace (since #2265) so you can freely use functions that it provides (although we currently support also older...

> To expand, I think vendoring libbpf is really the only sane long term solution. It is more or less inevitable that we will have to carry some out of...