Viktor Malík

Results 349 comments of Viktor Malík

It depends on which tests you want to run: - Unit tests can be run with `build/tests/bpftrace_test`. - Runtime tests can be run with `build/tests/runtime-tests.sh`. Running these in a container...

What is the purpose of using the `trigger:` or `event:` prefix? To logically group probe types which fire when the bpftrace process is a target of an event (signal, keypress)?...

> I guess another reason for grouping them behind a single probe type would be that it makes it clear that it's not tracing any signal or keypress systemwide -...

> Should this also deprecate the ability to print maps when issuing a SIGUSR to bpftrace? Seems strange to have both. https://github.com/bpftrace/bpftrace/blob/master/man/adoc/bpftrace.adoc#map-printing I think the PR removes the functionality but...

> hmm. while defining a signal probe changes the default behavior, still it's not a breaking change for those who don’t use it. does it really need a migration guide...

Also cc @andreasgerstmayr who added the original "print maps on SIGUSR1" feature.

Yeah, `self` sounds good and probably expresses the purpose better (the "target" is the current bpftrace process). No strong opinion on my side.

@jordalgo is this resolved by #3536?

> If you really feel strongly, I will try to tease it apart but at this point it feels like a bit of a pain and late to do so....

They don't support working with `args` without accessing any field. For instance: ``` # bpftrace -e 'tracepoint:syscalls:sys_enter_read { print(args) }' stdin:1:38-49: ERROR: struct _tracepoint_syscalls_sys_enter_read type passed to print() is not...