Viktor Malík
Viktor Malík
> Are "full expansion" and "multi expansion" meant to be mutually exclusive? An enum instead of two bools might be clearer/safer if that's the case. Indeed they are, a great...
While rebasing onto master, I noticed that uprobe_multi expansion doesn't work with placing uprobes after the funtion prologue. I opened #3173 to track that issue and this PR respects the...
> I'm not keen on using environment variables to mock behaviour - it runs the risk of something dodgy happening if a user sets the env var at run time....
> Sorry for taking so long to review! Just got a few minor points, but overall looks good to me. Thanks for the review! While updating the PR, I discovered...
Yes, I know about this issue and it's as you say - changes in the `build` command are occasional so I prefer not to waste test time on building. The...
> It is possible to introduce custom flag to pytest and then add some logic around it, it is docuemented [here](https://github.com/viktormalik/diffkemp_/blob/2c876c431fde337176d411df493ffa17db54d044/tests/regression/mock_source_tree.py#L41). Thanks for the link. Let's first resolve the test...
> * The new component is off by default and must be enabled using `--use-smt`. Do we always want to build this extension? The problem is that it introduces `z3`...
Hint: when you debug this, try to `cd` to the kernel directory and manually run a build command, e.g.: ``` $ make V=1 --just-print block/genhd.o ``` That should also halt...
Thanks for the analysis @PLukas2018. Updating `rhel-kernel-get` won't help here as this particular config is probably missing b/c the compiler in the Nix environment has different features than the one...
Thanks for the analysis! It's possible that it'd just require to add one or two specific passes for the tests to pass. It may also be the case that `-O2`...