Viktor Malík

Results 349 comments of Viktor Malík

> One pretty major issue I've found it that this doesn't work! I haven't looked into why yet. > > Delete doesn't delete: > > ``` > $ sudo ./src/bpftrace...

Thanks for the reviews @ajor and @danobi! I believe I addressed all of your comments (except for adding semantic tests for particular error messages). I didn't resolve any comments so...

clang-format failure is fixed by #2978.

> Do we still need this now that looping over map elements is supported? Good question. @ajor I remember that you had a use-case for this at Meta. Is it...

Agreed. Let's close this one and we may reiterate on the nicer syntax in future (maybe along with adding other map "batch" operations).

> * Double down on docker but use quay.io to cache and explicitly rotate the base images. This would make the builds more reproducible, while retaining much of the current...

> > As a matter of that, we could also provide a script which would fill the necessary docker run parameters, especially mount the necessary volumes. > > I would...

I'd suspect function-like macros to be much more complicated to handle than simple one-line object-like macros that we support now. I'd rather invest energy into implementing proper function support, though...

The flowindent feature of dtrace is a nice thing and could be useful for bpftrace, too. Let's imagine the following script to see all BTRFS calls while processing the `getdents64`...