godu icon indicating copy to clipboard operation
godu copied to clipboard

support unicode string display

Open leslie-wang opened this issue 5 years ago • 2 comments

Signed-off-by: Leslie Qi Wang [email protected]

  • [Y] I've read Contribution guide
  • [T] I've tested everything that doesn't relate to tcell.Screen API
Screen Shot 2020-01-20 at 11 39 23 PM

Close https://github.com/viktomas/godu/issues/76

leslie-wang avatar Jan 21 '20 07:01 leslie-wang

Codecov Report

Merging #77 into master will decrease coverage by 0.78%. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage     100%   99.21%   -0.79%     
==========================================
  Files           7        7              
  Lines         248      255       +7     
==========================================
+ Hits          248      253       +5     
- Misses          0        1       +1     
- Partials        0        1       +1
Impacted Files Coverage Δ
interactive/reporter.go 96.87% <75%> (-3.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af23dd1...5e545a7. Read the comment docs.

codecov-io avatar Jan 21 '20 07:01 codecov-io

@leslie-wang thanks for another contribution! It's great to see the handling of edge case like this. Please make sure you add tests for all code that you add.

Could you please check whether it would be possible to use the native range loop or the native utf8 library to avoid adding unnecessary dependencies?

viktomas avatar Jan 22 '20 07:01 viktomas