vikramlearning
Performance Optimizations
Continues from https://github.com/vikramlearning/blazorbootstrap/pull/747
If you let Blazor itself fill the Parameter/CascadingParameter items, it causes a kind of System.Reflection magic which is not great for performance. This is fine for pages or components which aren't used over and over, but for things like buttons this is very performance intensive. By setting the parameters ourselves, pages and components are rendered a tad faster, and this creates a noticable improvement when rendering things like Grids.
Apart from that, this PR contains little changes: more added documentation and a bugfix for AccordionItems.
@Lucasharskamp I appreciate :clap: your efforts on this pull request (PR) . This is a very large PR. I don't have any intention of holding up any PRs unless they introduce too many changes. This PR introduces too many changes in one go. I cannot merge this PR as-is. I'll take care of this PR, so don't worry about out-of-sync changes; I'll merge the changes step-by-step. For Light and Dark mode, I'm looking for a better way to implement it. Performance optimization is definitely needed for improvements.
Can you share the Accordion bug fix information for my understanding?
@Lucasharskamp I appreciate 👏 your efforts on this pull request (PR) . This is a very large PR. I don't have any intention of holding up any PRs unless they introduce too many changes. This PR introduces too many changes in one go. I cannot merge this PR as-is. I'll take care of this PR, so don't worry about out-of-sync changes; I'll merge the changes step-by-step. For Light and Dark mode, I'm looking for a better way to implement it. Performance optimization is definitely needed for improvements.
Can you share the Accordion bug fix information for my understanding?
Reminder that these were far smaller but you kept pushing changes, causing me to have to re-merge it with new features. Bit of a snowball effect.
Added disabled buttons color/bg color/border color for the CSS generator.
@gvreddy04 Merged back with main, fixed some issues in your code in relation to charts.
Also: chartdata should be double? and not double. Why? Because nullable data, to say skip x-positions in a linechart, is a feature of chartjs.
@gvreddy04 Note: the ''static code fail'' is because I added a new rule, namely that all public interfaces (methods, classes, etc) that end users can use must have XML summaries, and they're lacking on a lot of code.