drupal-quality-checker icon indicating copy to clipboard operation
drupal-quality-checker copied to clipboard

grumphp version used is not compatible with PHP 8

Open ptmkenny opened this issue 3 years ago • 4 comments

I tried to update to Drupal 9.3 with PHP 8 this morning and got blocked because the version of grumphp used here does not support PHP 8+.

ptmkenny avatar Dec 09 '21 02:12 ptmkenny

It also looks like:

sebastian/finder-facade and sebastian/phpcpd also need to be updated for PHP 8

lagates avatar Feb 18 '22 14:02 lagates

created https://github.com/vijaycs85/drupal-quality-checker/pull/37 to update versions

lagates avatar May 02 '22 14:05 lagates

It looks like this was downgraded to support PHP <= 7 in this commit: https://github.com/vijaycs85/drupal-quality-checker/commit/9c6d10367c3a2fe88e14f0d25ea36a0c9db1d1a7

malcomio avatar May 30 '22 09:05 malcomio

I've created #38, which seems to work locally - @lagates what was the reason you closed #37?

malcomio avatar May 30 '22 09:05 malcomio