Daniel Vigovszky

Results 135 comments of Daniel Vigovszky

No, to `ZIO.logError` etc (https://zio.dev/reference/observability/logging/)

Sorry previously I did not properly check where the logging is added and only reacted to how is it logging. I would not add any logging into constructors of a...

> An additional question could be whether we always want to do this logging or not. I'm not sure about it - maybe there could be a fiber ref to...

> @jdegoes another easy option would be to break abstraction a little bit and handle it in `zio.http.netty.AsyncBodyReader#connect`. Instead of submitting chunks one by one > > ```scala > buffer.result().foreach...

Some random thoughts, only by looking at the code, did not play with it: - it can be confusing what middleware you have to pass to this `Routes` constructor an...

I think the solution to this should be that `ServerLive` lazily calls `NettyDriver#start` when the first `install` call happens instead of during its initialization

It would be nice to better understand what these custom pipelines would do; The default pipeline is constructed in a way to support all the features built on top of...

I agree, as we already depend on `zio-schema` and `zio-json` for the endpoint API we could have constructors for `Body/Request/Response` directly using `JsonCodec` or `Schema`