Viggo de Vries

Results 18 comments of Viggo de Vries

hahah definitely tests, was curious if the current tests would still pass.

Hey @laf0rge We have been able to solve this in our own stack So in the strategy you do have the user: https://github.com/django-oscar/django-oscar/blob/master/src/oscar/apps/partner/strategy.py#L62 We have a one-step checkout which makes...

Adding to this, I think there can be some improvements in Oscar to make it easier to do this but I don't think there is a good out of the...

Sorry to hear you're looking at other options. You can keep track of the `tax_code` reference on the order lines, surcharge and for the shipping methods. this way you still...

@nakarinh14 thanks for this! I would really like to see a test which shows this didn't work before and proof that this code actually works!

@samar-hassan could you give @zain93393 some directions to fix this?

@samar-hassan I think you need to edit a migration because the make migration test failed now.

@samar-hassan please edit the existing migration, a new migration for choices is not needed!

Rebased these changes into: #4098 so we can test everything against python 3.10 before merging into main

@nakarinh14 the `index_queryset: return self.get_model().objects.browsable().order_by('-date_updated')` should already take care of this right?