colonel-kurtz icon indicating copy to clipboard operation
colonel-kurtz copied to clipboard

[WIP] Upgrade Dependencies

Open solomonhawk opened this issue 4 years ago • 2 comments

WORK IN PROGRESS

Pending feedback from @nhunzaker

Deploy preview: https://deploy-preview-157--colonel-kurtz.netlify.app/

Note: still working on a few remaining things.

Upgrading prettier yielded some different formatting style things which affect a majority of the code. I broke this out into it's own commit so hopefully viewing the other changes isn't too difficult (by looking at individual commits). As a result, the "files changed" view is going to be a little noisy.

I also messed this up a bit - you can see a lot of the files (mostly tests) touched as part of ee899b47 were auto-formatted by my editor. Sorry :(

Questions:

  • Is specifying node 12.13 too prescriptive? I think most of the updated deps here would be satisfied by node 10.x
  • What am I forgetting to update/change?

TODO:

  • Review all docs to ensure they are up to date, carve out a spot for a note about upgrading (mainly just not needing to call editor.start() and the change from editor.listen(fn) to editor.on('change', fn))
  • Bump major version
  • Update Changelog with new version #
  • Tag & push, release to NPM

solomonhawk avatar May 10 '20 22:05 solomonhawk

Codecov Report

Merging #157 into master will decrease coverage by 0.18%. The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   93.91%   93.72%   -0.19%     
==========================================
  Files          33       34       +1     
  Lines         296      303       +7     
  Branches       43       43              
==========================================
+ Hits          278      284       +6     
- Misses         16       17       +1     
  Partials        2        2              
Impacted Files Coverage Δ
src/actions/blocks.js 80.00% <ø> (ø)
src/components/App.js 100.00% <ø> (ø)
src/components/BlockTypeGroup.js 14.28% <ø> (ø)
src/components/EditorBlock.js 100.00% <ø> (ø)
src/utils/insertAt.js 100.00% <ø> (ø)
src/utils/siblingAt.js 100.00% <ø> (ø)
src/components/Block.js 92.30% <80.00%> (ø)
src/components/SwitchNav.js 89.47% <83.33%> (-4.65%) :arrow_down:
src/Colonel.js 100.00% <100.00%> (ø)
src/components/Animator.js 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 99cb4a6...a9177df. Read the comment docs.

codecov-io avatar May 10 '20 22:05 codecov-io

@nhunzaker Just a gut check is all I was really looking for. We're poised to take ownership here but I wanted to give you an opportunity to surface any relevant thoughts, opinions, or history/guidance.

solomonhawk avatar May 14 '20 21:05 solomonhawk