kimuraframework icon indicating copy to clipboard operation
kimuraframework copied to clipboard

Ruby 2.7 support: Switch to Addressable.URI.escape away from obsolete URI.escape

Open johnphamvan opened this issue 4 years ago • 11 comments

Addresses https://github.com/vifreefly/kimuraframework/issues/42

johnphamvan avatar May 13 '20 19:05 johnphamvan

@vifreefly Hi! Could you please take a look at this PR when you have a free moment? Thanks for creating and maintaining this project!

johnphamvan avatar May 21 '20 17:05 johnphamvan

@vifreefly Hi. Could you please provide feedback or consider accepting this PR? Also, would you be interested in having some help maintaining this project?

johnphamvan avatar Jun 25 '20 16:06 johnphamvan

@vifreefly any updates here?

dallasgoldswain avatar Jul 27 '20 19:07 dallasgoldswain

Just hit this myself after upgrading to 2.7. I presume the best course of action is to fork this as it doesn't seem to be maintained anymore

doutatsu avatar Apr 21 '21 21:04 doutatsu

@doutatsu We're considering maintaining a fork, adding some test coverage, and adding Chrome CDP support via the ferrum gem. Be interested in helping?

johnphamvan avatar Apr 21 '21 21:04 johnphamvan

@johnphamvan Potentially. Need to evaluate what other gems are out there, as I had another one recommended, so would have to see if I want to stick with Kimura

doutatsu avatar Apr 21 '21 21:04 doutatsu

Hello @johnphamvan & @doutatsu

I do plan to start maintaining the project again soon, but at the moment I don't have enough time for it. We could start with @johnphamvan PR (great work by the way). What will you say?

vifreefly avatar Apr 21 '21 21:04 vifreefly

@vifreefly Squashed and updated CHANGELOG.md.

johnphamvan avatar Apr 28 '21 04:04 johnphamvan

Hi @vifreefly thanks for making this library. Would you consider adding some maintainers to this project to keep it moving along? It'd be nice to have it working on Ruby 3 without needing forks.

dkam avatar Nov 21 '21 23:11 dkam

I'd be interested in helping out as a contributor as well!

nick-symon avatar Feb 27 '22 01:02 nick-symon

Hey guys, I would love to see your contributions on Tanakai (Kimurai fork), it already got support to Chrome CDP.

glaucocustodio avatar Aug 13 '22 15:08 glaucocustodio