Viktor Kopp

Results 46 comments of Viktor Kopp

I would think of replacing this graph with something smarter as contribution is not only how many lines added, but also how many lines removed. Perhaps, it is worth to...

> Maybe number of "owned" line (as in git blame) would be more interesting, but not as easy to collect. this is technically easy to collect, but extremelly slow. for...

Has the template file qface/templates/qface/qtcpp.j2 been forgotten in qface codebase when concrete generators had been separated from the project? It looks like it should be moved to https://github.com/Pelagicore/qface-qtcpp as very...

I agree this leads to some boilerplate, but I did not want to extend that matrix intentionally to check Qt6. Anyway, this is just a draft which I have not...

> And in my point of view, a move to qt6 should also happen on Linux and Windows too I agree, but not necessarily simultaneously. Btw, migration to Qt6 has...

@hannesa2 if you have a mac machine, this PR now generates a mac bundle, would you be able to check whether app can be launched from the bundle?

@bunty95 @hannesa2 I do not have mac, but because I desperately want us to migrate to qt6, I made this work blindly relying on ci. Further progress on my side...

@hannesa2 @bunty95 @nickelpot could somebody try the bundle after @bunty95 added signing and notarization? According to what @nickelpot said, this should now work without issues on macos-15

> I think we can merge this into the main branch. I somewhat share the @hannesa2 's concern here https://github.com/COVESA/dlt-viewer/pull/670#discussion_r2157443083 So I guess I will try to squeeze these changes...

> Either in matrix or replace 5 with 6 complete. @hannesa2 I still do not feel confident simply replacing to qt6 in that matrix job, it would require additional efforts...