gocover.io Use Docker Host env

Use Docker Host env

Open nathany opened this issue 10 years ago • 5 comments

This is an easy way to get it working on a Mac. Not sure if it still all works on Linux and how it affects the deploy.

closes #10

Jan 10 '15 19:01 nathany

Thanks!

I'm actually using swarm instead of docker directly. So I would prefer a flag. Let's replace -s with -H like docker and so

./server -H $DOCKER_HOST in the readme.

Jan 12 '15 19:01 vieux

Sounds good.

Jan 13 '15 00:01 nathany

PTAL

Jan 13 '15 00:01 nathany

@nathany LGTM sorry to bother you, but can you use the official redis images instead of crosbymichael/redis

Thanks

Jan 13 '15 00:01 vieux

sure, no problem.

if you tire of waiting for contributors to make a small change, check out: http://blog.spreedly.com/2014/06/24/merge-pull-request-considered-harmful/

Jan 13 '15 05:01 nathany