Julien Viet

Results 1278 comments of Julien Viet

as I understand the goal is that cached prepared statement survive between two connection pool usage of the same physical connection so they don't need to be prepared again.

it should be rebased on master, reviewed and finished

I think equals/hashcode should not be implemented by this class.

so we should fix this bug and likely fix the existing equals/hashCode

the implementation of equals is actually wrong because it calls super.equals that is not implemented.

also the uri parser does a String key = parameterPair.substring(0, indexOfDelimiter).toLowerCase(); that I cannot explain

I think the idea is that some extra parameters of the connect options can be used from the JSON and apply to the vertx connect options, e.g specifying the idleTimeOut...

so we could have unrecognised options as properties ? e.g do something like 1. parse to JSON 2. create connect options from JSON 3. transform connect options to JSON 4....

e.g ```java public static PgConnectOptions fromUri(String connectionUri) throws IllegalArgumentException { JsonObject parsedConfiguration = PgConnectionUriParser.parse(connectionUri); PgConnectOptions options = new PgConnectOptions(parsedConfiguration); JsonObject foobar = options.toJson(); for (Map.Entry entry : parsedConfiguration) { if...

what are the common connection properties that are not yet supported from URI parsing, e.g for PG.