react-native-spotify icon indicating copy to clipboard operation
react-native-spotify copied to clipboard

Published 20 hours ago • verified publisher icon viestat

Illegal callback invocation from native module

Open digitaldavenyc opened this issue 7 years ago • 4 comments

I know this repo has not received a lot of love lately but this is a fairly critical issue. After upgrading to RN 0.44, logging in with Spotify via facebook produces the following error.

screen shot 2017-08-27 at 11 32 51 pm

The issue seems to be fairly well documented and happened with a lot of other RN libraries

https://github.com/zmxv/react-native-sound/issues/152 https://github.com/facebook/react-native/issues/13595

digitaldavenyc avatar Aug 28 '17 03:08 digitaldavenyc

I'm working on a solution this but I am having some trouble getting EventEmitter to work correctly. I've posted the issue on stackoverflow here: https://stackoverflow.com/questions/45952936/react-native-eventemitter-not-registering-events

If someone could lend some advise it would be very helpful in getting a PR submitted.

digitaldavenyc avatar Aug 30 '17 05:08 digitaldavenyc

@digitaldavenyc I will have a look at it too, thanks for reporting this 👍

viestat avatar Sep 08 '17 13:09 viestat

@digitaldavenyc I was working on https://github.com/viestat/react-native-spotify/pull/16 Maybe you can already check it out while I finalise it

viestat avatar Sep 08 '17 15:09 viestat

@viestat I'd be happy to let me know when you think it's good to go. I don't know if upgrading will fix this issue though because it does seem to be partially a react-native flaw with callbacks.

digitaldavenyc avatar Sep 08 '17 16:09 digitaldavenyc