klipse icon indicating copy to clipboard operation
klipse copied to clipboard

Published 20 hours ago • verified publisher icon viebel

when hosting Klipse locally, fonts are loaded from the internet

Open lechten opened this issue 4 years ago • 5 comments

Hi, I'm using the master version, following "Host Klipse locally". Differently from #334, I'm using the non-minified version here.

If I add klipse_settings.no_dynamic_scripts=true;, evaluation of code fails with: TypeError: a.split is not a function, while it (almost) works without that setting.

The piece that is not working is that I see a web request for https://viebel.github.io/klipse/fonts/FiraCode/woff/FiraCode-Regular.woff. This request should not be necessary as that resource is part of the dist directory. How can I avoid this?

lechten avatar Apr 23 '20 07:04 lechten

That's definitely a bug. You can fix it by modifying this file: https://github.com/viebel/klipse/blob/57e5312e88425811183a838f63afd4a92077fada/dist/codemirror.css

Please provide a PR.

viebel avatar Apr 27 '20 06:04 viebel

I opened a PR for the font issue.

When should klipse_settings.no_dynamic_scripts=true; be necessary?

lechten avatar Apr 28 '20 12:04 lechten

@Verdinjoshua26 started working on this issue via WorksHub.

workshub[bot] avatar Apr 30 '21 11:04 workshub[bot]

@rainbow-bamboo started working on this issue via WorksHub.

workshub[bot] avatar May 27 '21 21:05 workshub[bot]

A user started working on this issue via WorksHub.

workshub[bot] avatar Jul 10 '21 23:07 workshub[bot]