player icon indicating copy to clipboard operation
player copied to clipboard

Playback Quality Support

Open mihar-22 opened this issue 4 years ago • 0 comments

Tasks

Design and implement an interface to support getting/setting playbackQuality across providers.

Notes

Properties

  • playbackQuality: string
  • playbackQuality: string[]
  • canSetPlaybackQuality: boolean

Events

  • vds-playback-quality-change
  • vds-playback-quality-change-request

Important

  • playbackQuality can only be set to a valid value in playbackQuality.
  • How to know if the current provider supports setting playbackQuality? The interface designed should account for this via the canSetPlaybackQuality property. Refer to the canRequestFullscreen property on the MediaContext for a similar implementation.

References

  • https://github.com/vime-js/vime/blob/master/core/src/components/core/player/PlayerProps.ts#L268-L284
  • https://github.com/vime-js/vime/blob/master/core/src/components/providers/MediaProvider.ts#L23-L24
  • https://github.com/vime-js/vime/blob/master/core/src/components/providers/hls/hls.tsx#L247-L254
  • https://github.com/vime-js/vime/blob/master/core/src/components/providers/dash/dash.tsx#L303-L330

mihar-22 avatar Feb 02 '21 01:02 mihar-22