player icon indicating copy to clipboard operation
player copied to clipboard

On mobile, buttons underneath the settings modal get triggered when buttons on the modal are clicked

Open geerew opened this issue 1 year ago • 1 comments

Current Behavior:

On mobile, when you click the settings button, it opens a more mobile friendly modal.

If you click one of the buttons, for example, playback, and there is button behind the model in the position you click, the event will trigger for playback, but also travel through the modal, to the button behind, triggering that button as well

Expected Behavior:

Events on the modal should not 'fall through' to buttons behind the modal.

Steps To Reproduce:

  1. On mobile, navigate to https://www.vidstack.io/player/demo
  2. Click the settings button
  3. Click roughly in the middle of playback

This will trigger the styles.css button underneath

I have the same experience on my own site

geerew avatar Jun 11 '24 19:06 geerew

Example video ..

In it I

  1. Refresh the page
  2. Click the settings button on the video player
  3. Click the middle of the playback button

This event bubbles through the modal to the styles.css button behind on page load config.json is selected), which triggers other behaviour on my mobile

https://github.com/vidstack/player/assets/494875/58fc6926-9df8-4908-ad51-02d09af88a7c

geerew avatar Jun 11 '24 19:06 geerew

Thanks for reporting! This seems to only be a bug on our site, something to do with the code editor. I'll look into it separately.

mihar-22 avatar Jul 05 '24 03:07 mihar-22

Hey @mihar-22 ! We experiencing the exact same thing on our site! Are you sure this is not a bug in the lib? Could you look into it? Thanks in advance!

borbelyr-byborg avatar Nov 13 '24 15:11 borbelyr-byborg