videomorph icon indicating copy to clipboard operation
videomorph copied to clipboard

Release 1.5 Canelo

Open lpozo opened this issue 4 years ago • 6 comments

lpozo avatar Jan 24 '21 20:01 lpozo

Codecov Report

Merging #61 (9c8f36d) into master (c4764d1) will decrease coverage by 25.34%. The diff coverage is 36.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #61       +/-   ##
===========================================
- Coverage   48.51%   23.16%   -25.35%     
===========================================
  Files           9       24       +15     
  Lines         470     1787     +1317     
  Branches       53      179      +126     
===========================================
+ Hits          228      414      +186     
- Misses        238     1355     +1117     
- Partials        4       18       +14     
Impacted Files Coverage Δ
videomorph/__init__.py 100.00% <ø> (ø)
videomorph/converter/console.py 0.00% <0.00%> (ø)
videomorph/converter/task.py 0.00% <0.00%> (ø)
videomorph/converter/tasklist.py 0.00% <0.00%> (ø)
videomorph/converter/timer.py 47.82% <ø> (ø)
videomorph/forms/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
videomorph/forms/about.py 0.00% <0.00%> (ø)
videomorph/forms/changelog.py 0.00% <0.00%> (ø)
videomorph/forms/info.py 0.00% <0.00%> (ø)
videomorph/forms/videomorph.py 0.00% <0.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ccbfeb8...9c8f36d. Read the comment docs.

codecov[bot] avatar Jan 24 '21 20:01 codecov[bot]

@lpozo @codeshard Great news! So, is this actually ready for release? I see one test still failing... what's the next step in this case?

leonel-lordford avatar Jan 24 '21 20:01 leonel-lordford

@leonel-lordford Next step is to make the test pass.

lpozo avatar Jan 24 '21 20:01 lpozo

@codeshard What do you think this is: ERROR: Failure: ValueError (Command ffmpeg not found). Is TravisCI failing to install ffmpeg?

lpozo avatar Jan 24 '21 21:01 lpozo

@leonel-lordford Next step is to make the test pass.

Ok! I think the process is failing because ffmpeg is missing in the env... I think :-D So... are we sure about what's failing?

leonel-lordford avatar Jan 24 '21 21:01 leonel-lordford

@codeshard What do you think this is: ERROR: Failure: ValueError (Command ffmpeg not found). Is TravisCI failing to install ffmpeg?

Exactly! I think that is the problem...

leonel-lordford avatar Jan 24 '21 21:01 leonel-lordford