vlc-ios icon indicating copy to clipboard operation
vlc-ios copied to clipboard

tvOS: NetworkStream UI: Add sorting button new to old

Open embeddedc opened this issue 3 years ago • 4 comments

Checklist

  • [ ] I've run bundle exec fastlane test from the fastlane directory to see all new and existing tests pass
  • [ ] I've followed the vlc-ios code style
  • [ ] I've read the Contribution Guidelines
  • [ ] I've updated the documentation if necessary.

Description

It is annoying that new stream URLs are added at the bottom to the list, so you have to scroll down to resume a recent stream.

Can we add a setting to change this behavior? Alternatively I added a "reverse sorting" button with this PR.

embeddedc avatar Aug 16 '22 17:08 embeddedc

Why not always show the last stream first like in the iOS interface?

fkuehne avatar Aug 19 '22 12:08 fkuehne

Why not always show the last stream first like in the iOS interface?

I like my button. 😀

Does this really work differently on iOS? The logic seems to be the same?

Also I don't understand https://github.com/videolan/vlc-ios/blob/b7bf94f1e06c38aa8c956e32207cdb2cc107520f/Sources/VLCOpenNetworkStreamViewController.m#L262 With the current order, this removes the latest not the oldest entry?

Would you prefer a PR for https://github.com/embeddedc/vlc-ios/commit/6aba00bf23ba4b2ae8f41d6f12b4b31e80e23f02?

That should reverse the sorting and fix above misbehavior..

embeddedc avatar Sep 02 '22 15:09 embeddedc

I prefer to not have a button at all and always have the latest stream at the top and the oldest at the bottom. This is the behaviour on iOS and that on tvOS, it is reverse is simply a bug.

A MR for the referenced commit would be appreciated on our own gitlab here: https://code.videolan.org/videolan/vlc-ios

Thank you!

fkuehne avatar Sep 06 '22 12:09 fkuehne