videojs-vimeo icon indicating copy to clipboard operation
videojs-vimeo copied to clipboard

Support for video.js ^6 greatly appreciated

Open lvl99 opened this issue 8 years ago • 4 comments
trafficstars

Aside from the out-of-date NPM package, some work to support the newest version of video.js would be much appreciated.

I had to download the files directly from this repo instead of using NPM, had to install the @vimeo/player dependency after a console error complained it wasn't there, then had to downgrade to video.js v5.20.1 due to errors like it not being able to register as a component because it is a tech.

lvl99 avatar Jul 25 '17 11:07 lvl99

Had similar errors with the current video.js version. Removing the "registerComponent" line seems to get it working at least on a basic level.

On the minimized version, remove the text: p.registerComponent("Vimeo",y),

I'm not familiar with the inner workings of video.js or this plugin, so I don't know if there are other version issues.

krabsheva avatar Jul 27 '17 03:07 krabsheva

@krabsheva Thanks, removing that line got rid of one error. Now I get this error. Any fix or update for this? TypeError: this.tech_[t] is not a function

seabasss avatar Sep 11 '17 22:09 seabasss

Remove this line: Component.registerComponent('Vimeo', Vimeo); And support for the 6+ works

Yeine avatar Oct 12 '17 18:10 Yeine

Here is an opened PR with added videojs 6.x compatibility: https://github.com/videojs/videojs-vimeo/pull/119

GeyseR avatar Oct 25 '17 06:10 GeyseR