video.js
video.js copied to clipboard
videojs
Player stuck after quality change and seek in rapid succession
Description
Briefly describe the issue. Include a reduced test case, we have a starter template on JSBin you can use.
Reduced test case !NB - I ended up copy-pasting the ENTIRE contrib quality levels in the file, as for some reason using a script src tag did not work for me. However, the contrib quality levels that is pasted in there is UNMODIFIED
When seeking backwards, if the video hasn't buffered enough, we ender an infinite loop.
Steps to reproduce
Explain in detail the exact steps necessary to reproduce the issue.
- Go to some moment on video (e.g. 70%)
- Switch to some quality (e.g. 1080p) (wait for first frame to load)
- Instantly switch to other quality (e.g. 240p)
- Instantly move progress bar to some earlier point in the video (e.g. 30%)
Notes: The video resumes if you go back to the video at the moment of the quality switch (in point 1), or any other time after that point (in the case of point 1 - 70% or after)
Error output
No errors are given whatsoever
Additional Information
Please include any additional information necessary here. Including the following:
versions
videojs
Tested on some versions > 7.10 (including latest, 7.11.5)
browsers
what browser are affected? Google chrome v88.0.4324.182 Mozilla Firefox v85.0.2
OSes
what platforms (operating systems and devices) are affected? Tested in Win10 - version 10.0.19041 Build 19041 (I have not checked in on phones, as it would be marginally difficult to fulfill the same steps there within such a short time period)
plugins
are any videojs plugins being used on the page? If so, please list them below. `videojs-contrib-quality-levels version 2.0.9 videojs-hls-quality-selector version 1.1.4
👋 Thanks for opening your first issue here! 👋
If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.
![welcome[bot] avatar](https://avatars.githubusercontent.com/in/4141?v=4 "Published by a pub.dev verified publisher"){kind=small}
Indeed. I do seem to no longer be able to reproduce it with the steps I provided in 7.12.3. However, switching to a different moment in the video, changing the resolution, switching again and changing again in rapid succession (basically repeated that for 5-6 times, as fast as I could) does indeed seem to eventually reproduce it.
I'm attaching a visual with the case.
https://imgur.com/a/pbNpOY0
(the second one is a link, as it is a bit too large to upload to github. I also let it run for a bit longer, to show that it's not a matter of waiting*)
*Currently still stuck, I've left it for some 15-20-ish minutes.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
