video.js
video.js copied to clipboard
controlBar.currentTimeDisplay does not apply.
Description
Briefly describe the issue. Include a reduced test case, we have a starter template on JSBin you can use.
Steps to reproduce
Explain in detail the exact steps necessary to reproduce the issue.
- option ---> { controlBar: { currentTimeDisplay: true } } does not apply.
- option ---> { controlBar: { remainingTimeDisplay: false, currentTimeDisplay: true } } does not apply.
Results
Expected
Please describe what you expected to see. off remainingTimeDisplay, on currentTimeDisplay
Actual
Please describe what actually happened.
- option ---> { controlBar: { currentTimeDisplay: true } } on remainingTimeDisplay
- option ---> { controlBar: { remainingTimeDisplay: false, currentTimeDisplay: true } } just off remainingTimeDisplay
Error output
If there are any errors at all, please include them here.
Additional Information
Please include any additional information necessary here. Including the following: This library is very useful. thank you.
versions
videojs
what version of videojs does this occur with? 7.1.0
browsers
what browser are affected? chrome and ie11
OSes
what platforms (operating systems and devices) are affected? Windows 10
plugins
are any videojs plugins being used on the page? If so, please list them below.
👋 Thanks for opening your first issue here! 👋
If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.
The control is present by default, but hidden by CSS. This would unhide it.
.video-js .vjs-current-time { display: block; }
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
+1, How did you solve it? I'll settle this for the time being:
`
.video-js .vjs-current-time, .vjs-no-flex .vjs-current-time {
display: block !important;
}
.vjs-time-divider {
display: block !important;
}
.video-js .vjs-duration, .vjs-no-flex .vjs-duration {
display: block !important;
}`
@mister-ben Thank you for this advise. If it should be set manually, no need to have it as option. Unless there is other way to toggle it out.
This is probably something that we should handle but it keeps not happening. Video.js should auto display those controls if explicitly enabled in options.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Looking forward to being able to display CurrentTimeDisplay in an easy way that doesn't look like I am hacking DOM elements' visibility by custom CSS.