mux.js icon indicating copy to clipboard operation
mux.js copied to clipboard

Basic support for FLAC-in-MP4 audio tracks

Open bvibber opened this issue 5 years ago • 4 comments

Allows for creating an MP4 stream with FLAC contents using the MP4 box generation functions or AudioSegmentStream.

Use codec string 'fLaC' and specify a 'metadata' field in the track info with the FLAC METADATA_BLOCK_HEADER fields to go into the dfLa box.

See https://github.com/xiph/flac/blob/master/doc/isoflac.txt for details of the MP4 embedding of FLAC audio.

bvibber avatar Jun 01 '19 16:06 bvibber

This is a cool feature, but we've got a lot on our plate right now so it might be a bit before we get a chance to review this.

squarebracket avatar Jun 11 '19 03:06 squarebracket

No worries, no rush. :)

bvibber avatar Jun 11 '19 04:06 bvibber

@brion hey, do you have some test content readily available we can take a look at? Thanks.

gkatsev avatar Feb 12 '20 19:02 gkatsev

@brion I tested out your pull request and I do see how this would help us generate flac-in-mp4 content. Since this doesn't seem to break mpeg ts transmuxing on our end I think we could merge this easily enough. It would be really helpful to get two things from you here so that we can get this in:

  1. Do you have an example of how you are using the mp4-generator directly so that we can test it locally?
  2. Can you add a unit test that runs through the mp4-in-flac generation code paths?

brandonocasey avatar Nov 03 '20 22:11 brandonocasey