http-streaming
http-streaming copied to clipboard
[Fix #983] - Introduce an initialization option to limit reloads of blacklisted playlists
This addresses #983 by introducing a new initialization option which allows clients to limit how many times the player will retry to load a previously-blacklisted playlist.
Description
Fixes #983 .
Specific Changes proposed
- Introduce a new initialization option called
maxBlacklistedPlaylistReloads
- Add a new condition before removing a previously-blacklisted playlist from the blacklist
- Update docs for
blacklistDuration
- Added a new test that demonstrates that a playlist is not re-tried after hitting the max # of retries set by
maxBlacklistedPlaylistReloads
Requirements Checklist
- [ ] Feature implemented / Bug fixed
- [ ] If necessary, more likely in a feature request than a bug fix
- [ ] Unit Tests updated or fixed
- [ ] Docs/guides updated
- [ ] Example created (starter template on JSBin)
- [ ] Reviewed by Two Core Contributors
💖 Thanks for opening this pull request! 💖
Things that will help get your PR across the finish line:
- Run
npm run lint -- --errors
locally to catch formatting errors earlier. - Include tests when adding/changing behavior.
- Include screenshots and animated GIFs whenever possible.
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Can we close this review out? It looks like the issue has been resolved.
Yup, since we have https://github.com/videojs/http-streaming#maxplaylistretries, I think this is more or less covered by that.