http-streaming icon indicating copy to clipboard operation
http-streaming copied to clipboard

[Fix #983] - Introduce an initialization option to limit reloads of blacklisted playlists

Open evanfarina opened this issue 4 years ago • 3 comments

This addresses #983 by introducing a new initialization option which allows clients to limit how many times the player will retry to load a previously-blacklisted playlist.

Description

Fixes #983 .

Specific Changes proposed

  1. Introduce a new initialization option called maxBlacklistedPlaylistReloads
  2. Add a new condition before removing a previously-blacklisted playlist from the blacklist
  3. Update docs for blacklistDuration
  4. Added a new test that demonstrates that a playlist is not re-tried after hitting the max # of retries set by maxBlacklistedPlaylistReloads

Requirements Checklist

  • [ ] Feature implemented / Bug fixed
  • [ ] If necessary, more likely in a feature request than a bug fix
  • [ ] Reviewed by Two Core Contributors

evanfarina avatar Nov 01 '20 17:11 evanfarina

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome[bot] avatar Nov 01 '20 17:11 welcome[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 26 '21 03:06 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 08 '22 22:01 stale[bot]

Can we close this review out? It looks like the issue has been resolved.

wseymour15 avatar May 12 '23 16:05 wseymour15

Yup, since we have https://github.com/videojs/http-streaming#maxplaylistretries, I think this is more or less covered by that.

gkatsev avatar May 12 '23 20:05 gkatsev