http-streaming icon indicating copy to clipboard operation
http-streaming copied to clipboard

cacheEncryptionKeys has no effect with subtitle streams

Open phloxic opened this issue 5 years ago • 9 comments

Description

Reduced test case can be found here.

Steps to reproduce

  1. AES encrypted HLS source with subtitle stream
  2. set cacheEncryptionKeys: true
  3. play and monitor GETting of key files

Results

Keys for video renditions are fetched once, key(s) for subtitles are re-fetched and not cached.

Expected

Key files for subtitle streams should be cached too.

phloxic avatar Oct 15 '20 23:10 phloxic

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

welcome[bot] avatar Oct 15 '20 23:10 welcome[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 25 '20 11:12 stale[bot]

Still happening with 7.11.1: Screen Shot 2020-12-31 at 15 22 54

phloxic avatar Dec 31 '20 15:12 phloxic

Could the "outdated" label be removed? imho the issue is not outdated. Thank you.

phloxic avatar Jan 11 '21 09:01 phloxic

oh, thank you bot

phloxic avatar Jan 11 '21 09:01 phloxic

Looks like a long time ago I wrote a response to this, and then this got lost in the churn. Thankfully, Firefox saved my response, which is posted below. A PR would be helpful, as it's clearly something we're unlikely to get to any time soon.


Looks like our VTT Segment Loader isn't aware of that option, but our regular segment loader is. It should be relatively straight forward to add.

gkatsev avatar Nov 30 '21 23:11 gkatsev

Wanted to look into this anyway, thanks for the nudge. Will have a go.

For the time being I had brushed this under the carpet somewhat by shamelessly increasing targetduration for vtt.

phloxic avatar Dec 01 '21 11:12 phloxic

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 17 '22 06:04 stale[bot]

unstale

phloxic avatar Apr 17 '22 07:04 phloxic

Any update onto this? Would also interest me to have this fixed ...

ghost avatar Mar 25 '23 19:03 ghost

@venomone - this is fixed I believe.

phloxic avatar Mar 26 '23 18:03 phloxic

Fixed via 66a5b17de192eee5d23fadba6a21f6a54f0eb34c

phloxic avatar Jun 03 '23 16:06 phloxic