http-streaming icon indicating copy to clipboard operation
http-streaming copied to clipboard

refactor: clean up parameters of excludePlaylist

Open gesinger opened this issue 1 year ago • 1 comments

Rename the parameters passed to excludePlaylist to make the logic easier to follow.

Requirements Checklist

  • [X] Feature implemented / Bug fixed
  • [ ] If necessary, more likely in a feature request than a bug fix
  • [ ] Reviewed by Two Core Contributors

gesinger avatar Aug 03 '22 20:08 gesinger

Codecov Report

Merging #1304 (c6b54bb) into next (206f099) will increase coverage by 0.00%. The diff coverage is 94.41%.

@@           Coverage Diff           @@
##             next    #1304   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          39       39           
  Lines        9791     9795    +4     
  Branches     2275     2277    +2     
=======================================
+ Hits         8447     8451    +4     
  Misses       1344     1344           
Impacted Files Coverage Δ
src/videojs-http-streaming.js 90.45% <84.90%> (+0.04%) :arrow_up:
src/dash-playlist-loader.js 90.05% <87.34%> (ø)
src/playlist-loader.js 95.00% <95.23%> (-0.03%) :arrow_down:
src/manifest.js 93.45% <100.00%> (ø)
src/media-groups.js 98.66% <100.00%> (ø)
src/playback-watcher.js 98.33% <100.00%> (ø)
src/playlist-controller.js 94.98% <100.00%> (ø)
src/playlist-selectors.js 87.05% <100.00%> (ø)
src/playlist.js 94.56% <100.00%> (ø)
src/rendition-mixin.js 94.73% <100.00%> (ø)
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 03 '22 21:08 codecov[bot]

Rebased for @gesinger to resolve conflicts due to master/main renaming.

misteroneill avatar Aug 19 '22 14:08 misteroneill