http-streaming icon indicating copy to clipboard operation
http-streaming copied to clipboard

handleQuotaExceededError causes video player to stuck

Open EternalC0der opened this issue 2 years ago • 1 comments

Hello,

I am developer at a video streaming platform, our video player is based on videojs. Our users have been complaining about video player getting stuck a lot lately (while video is buffered, so it's not a network problem)

Based on our investigations, we noticed that users who set the max buffer time to 5 minutes are facing this issue more often!

P.s: We are setting the max buffer time like this:

player.tech().vhs.options_.externVhs.MAX_GOAL_BUFFER_LENGTH = 300
player.tech().vhs.options_.externVhs.GOAL_BUFFER_LENGTH = 300

finally, we found out that this issue is happening when the current segment of the player (that is being played) gets deleted by handleQuotaExceededError_ function at This Line because timeToRemoveUntil contains our current segment too! Our segments are 4 seconds.

Solution?

We expect videojs to let us allow to set MIN_BACK_BUFFER manually, so we could set it to a bigger number so that it does not remove the current-segment from loaded buffer.

Additional Information

videojs-http-streaming version

videojs-http-streaming 2.13.1

videojs version

video.js 7.18.1

Browsers

  • Mainly chromium (even on our desktop app, which uses Electron.js)
  • Firefox and other browsers

EternalC0der avatar Jul 11 '22 10:07 EternalC0der

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines.

welcome[bot] avatar Jul 11 '22 10:07 welcome[bot]