videogular2 icon indicating copy to clipboard operation
videogular2 copied to clipboard

Is videogular2 still being maintained?

Open Brhav opened this issue 4 years ago • 17 comments

The last release is from Jul 25

Brhav avatar Nov 07 '19 11:11 Brhav

Work continued after that release - the 'master' was updated as recently as 20 August, but not released.

wayne-optin avatar Nov 27 '19 22:11 wayne-optin

Looks dead to me. No maintenance of issues, last commit 20 Aug, Angular 9 around the corner which isn't compatible with the current NPM package.

jinder avatar Jan 27 '20 13:01 jinder

Sorry guys, I can't get time now to work on it :(

I would love to make it compatible (probably with a fresh start) with Angular 9 and Ivy tho.

Elecash avatar Jan 27 '20 14:01 Elecash

if we wait for the angular 9 ... 💀 it looks like it leaves before 2022 😅

GuilhermeBCC avatar Jan 28 '20 12:01 GuilhermeBCC

I've got a version that is ready for Ivy and packed as an angular-cli project. I probably won't have time to modify the Travis build and update this repo for at least a few more days. Would you have any time to help me with the Travis CI @EleCash . I've got the working code here if you are interested.

https://github.com/sliceofbytes/ngx-videogular

I would love to move this forward over the next couple weeks if not faster.

sliceofbytes avatar Jan 28 '20 23:01 sliceofbytes

@sliceofbytes I can't this weekend, but I'll try to have some time the next one :)

Elecash avatar Jan 29 '20 08:01 Elecash

@sliceofbytes what is this https://github.com/sliceofbytes/ngx-videogular ? is this basically the same as videogular2, but works with Angular 9 and Ivy? Is there a migration or if i use this it will be the same as well?

p3x-robot avatar Feb 07 '20 13:02 p3x-robot

I've moved to ngx-videogular and it works well. No node restriction and works with ivy out of the box.

jinder avatar Feb 07 '20 13:02 jinder

i tested it is perfect, thanks!

p3x-robot avatar Feb 07 '20 13:02 p3x-robot

@sliceofbytes are you planning on updating dependencies in your clone and transitioning it into a PR? I am asking since it is not a fork of the main project

I have an incomplete Angular 9-compatible fork running here: https://github.com/hitrecord/videogular2 it is not ready for a PR due to tests but appears to work based my brief manual testing in an Angular 9-based project. This is hosted on https://www.npmjs.com/package/@hitrecord/videogular2 (for now, with our goal of going back to the main branch)

jdodsoncollins avatar Feb 07 '20 19:02 jdodsoncollins

videogular2 is incompatible with node > 11.0.0:

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=10.9.0 <11.0.0". Got "12.16.1"

kzimny avatar Feb 23 '20 13:02 kzimny

videogular2 is incompatible with node > 11.0.0:

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=10.9.0 <11.0.0". Got "12.16.1"

https://github.com/sliceofbytes/ngx-videogular

p3x-robot avatar Feb 23 '20 15:02 p3x-robot

@p3x-robot you asked a very good question, which has not been answered:

Is there a migration or if i use this it will be the same as well?

I'm a bit concerned about the ngx-videogular package because this is not a clone. @Elecash what is your plan?

kzimny avatar Feb 23 '20 15:02 kzimny

i use it in a huge video app and no problems at all , i am on 9.0.2 with ivy.

p3x-robot avatar Feb 23 '20 16:02 p3x-robot

@sliceofbytes : did you get any answer from @Elecash ? Seems that videogular2 is not mantained anymore. The owner doesn't have time to migrate to v.9.x. Is your goal with ngx-videogular to go back to the main branch of videogular2?

kzimny avatar Feb 25 '20 07:02 kzimny

I've got a version that is ready for Ivy and packed as an angular-cli project. I probably won't have time to modify the Travis build and update this repo for at least a few more days. Would you have any time to help me with the Travis CI @Elecash . I've got the working code here if you are interested.

https://github.com/sliceofbytes/ngx-videogular

I would love to move this forward over the next couple weeks if not faster.

Hey Guys! Are you planning on merging these changes into this repo? or can we assume that this project is dead?

MarioC3 avatar Apr 23 '20 22:04 MarioC3

Hey, yes, I'll get to it as soon as possible.

Isaac-1010 avatar Apr 25 '20 18:04 Isaac-1010