ngx-videogular icon indicating copy to clipboard operation
ngx-videogular copied to clipboard

Published 20 hours ago • verified publisher icon videogular

Download Option

Open R00iBaard opened this issue 4 years ago • 3 comments

Hey,

Is there a way to add a download button within vg-controls?

R00iBaard avatar Nov 18 '20 13:11 R00iBaard

Good morning!

Well... Yes and no. Yes in the sense of you can download them with right-click -> Save video as and No as in we don't really have anything for configurable/dynamic/whatever download button.

That being said, I have 2 remarks:

  • Really awesome that you brought this up because it's one of those things that make a huge difference for the UX of the app
  • Since we have DRM/Encrypted media support, I need to double (and triple) check if we should expose the download by default and if it's possible to download them and the media is still playable. Else, disable those options.

Once again, massive thanks for bringing this up and taking time off your day to open this issue! Wish you a great rest of the week! 😄

IxquitilisSaid avatar Nov 19 '20 09:11 IxquitilisSaid

Thanks so much for the kind words and replying so fast 👍

So are you saying if I right click I should be seeing "Save Video As" image

Reason I'm asking again, before I did some other changes I could see the following... MicrosoftTeams-image (5)

R00iBaard avatar Nov 19 '20 10:11 R00iBaard

What did you change exactly? Just as an assumption, if you remove the default controls attribute from the video player, then you won't see them unless they are set via JS, which in turn could be missing the captions, PiP, and Download button.

Good thing you mention that since it could just be some prop missing in the Lib's VgControls

IxquitilisSaid avatar Nov 23 '20 08:11 IxquitilisSaid