video-transcoding-api icon indicating copy to clipboard operation
video-transcoding-api copied to clipboard

remove factory and store provider on providers list

Open flavioribeiro opened this issue 8 years ago • 2 comments

I've discussed with @fsouza about that, maybe storing the provider directly on providers list will reduce the overall complexity of the code. We should remove the factory and create a Validate() to be used on init().

flavioribeiro avatar Apr 05 '16 20:04 flavioribeiro

An important side effect of this change is that we would no longer support configuration files, only environment variables, because packages all inits are called before main, and we read the path and parse the config file in main.

We currently use environment variables, and it is indeed an approach that I prefer, so I'm +1 for this change.

It's worth mentioning that we're breaking the Gizmo way of handling configuration, but that's actually a good thing.

fsouza avatar Apr 05 '16 20:04 fsouza

We recently dropped support for file-based configuration in our APIs, so this is no longer a question.

fsouza avatar Aug 08 '16 14:08 fsouza