hls.js icon indicating copy to clipboard operation
hls.js copied to clipboard

Published 20 hours ago • verified publisher icon video-dev

feat: sideEffects to package.json

Open denisx opened this issue 1 year ago • 3 comments

Add sideEffects to have better code split

This PR will...

Help budlers cut unused code when you use named import/export

denisx avatar Dec 04 '24 06:12 denisx

I compare builds (master and this pr). There are no difference beetween mjs, and about 1.5Kb at js.

denisx avatar Dec 21 '24 12:12 denisx

https://github.com/video-dev/hls.js/actions/runs/12154224025/job/33989518911#step:7:1

2024-12-05T17:21:25.2296119Z Finished in 0 secs / 0 secs @ 17:21:25 GMT+0000 (Coordinated Universal Time)
2024-12-05T17:21:25.2297011Z 
2024-12-05T17:21:25.2297413Z SUMMARY:
2024-12-05T17:21:25.2299640Z ✔ 0 tests completed
2024-12-05T17:21:25.3183742Z ##[error]Process completed with exit code 1.

robwalch avatar Dec 21 '24 15:12 robwalch

Removing from the next milestone. The change breaks the test runner. If you'd like to make this change, please investigate a change to the test runner that doesn't depend on side-effects.

robwalch avatar Feb 12 '25 00:02 robwalch