hls.js icon indicating copy to clipboard operation
hls.js copied to clipboard

Seeing regression With 5818 MR

Open rajeshdish opened this issue 1 year ago • 4 comments

What version of Hls.js are you using?

1.5.x (latest)

What browser (including version) are you using?

5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36

What OS (including version) are you using?

MACOS

Test stream

No response

Configuration

{}

Additional player setup steps

No response

Checklist

  • [X] The issue observed is not already reported by searching on Github under https://github.com/video-dev/hls.js/issues
  • [X] The issue occurs in the stable client (latest release) on https://hlsjs.video-dev.org/demo and not just on my page
  • [X] The issue occurs in the latest client (main branch) on https://hlsjs-dev.video-dev.org/demo and not just on my page
  • [X] The stream has correct Access-Control-Allow-Origin headers (CORS)
  • [X] There are no network errors such as 404s in the browser console when trying to play the stream

Steps to reproduce

Expected behaviour

During Seek Back Playback should continue

What actually happened?

Everytime we seek backwards we have to provide new URL to player, we call stopLoad> loadSource(with new URL) during this time we are seeing this error and loadSource is not working (in playback only one segment keep repeating itself with freezes)

All fragments start & end time is in negative values

Screenshot 2023-09-19 at 6 52 51 AM

this delta is going negative values (eg: -3232 | -2332) with this changes playback started to work.

Screenshot 2023-09-19 at 8 53 27 AM

OR

Screenshot 2023-09-19 at 9 21 06 AM

Console output

NONE

Chrome media internals output

No response

rajeshdish avatar Sep 20 '23 02:09 rajeshdish

Hi @rajeshdish,

Please provide steps that we can follow to reproduce the bug. The bug report is missing a sample stream and precise steps.

robwalch avatar Sep 20 '23 15:09 robwalch

From the description, it sounds like you are not supplying consistent Program-Date-Time values in and across media Playlists.

with this changes playback started to work.

Those changes would prevent playlist alignment working as intended which suggests the issue is in your HLS authoring.

robwalch avatar Sep 20 '23 15:09 robwalch

Live: #EXT-X-PROGRAM-DATE-TIME:2023-09-21T03:45:19.916Z

Stream can go back to specific time. i have Seeked backwards to 13 min before live #EXT-X-PROGRAM-DATE-TIME:2023-09-21T03:32:11.436Z

In this MR we are referring to previous loaded Level right! and does this align with this case also? previous loaded level contains live fragments & we are calculating delta using those fragments.

rajeshdish avatar Sep 21 '23 03:09 rajeshdish

Please provide a live sample with steps to reproduce.

robwalch avatar Sep 21 '23 09:09 robwalch

Closing as steps to repro have not been provided, and invalid playlist updates are resulting in negative duration calculation.

Please provide steps to reproduce or a PR with a comprehensive test (see the test below for an example) so that we can reopen:

https://github.com/video-dev/hls.js/blob/ec4fcc59ddc6c96bf33bcbf486d9b96633e2bf9a/tests/unit/controller/level-helper.ts#L266

robwalch avatar May 13 '24 18:05 robwalch