Vincent Delecroix

comment:15 update milestone 8.3 -> 8.4

comment:17 Instead of specifying the dependencies in the extension as ``` Extension('sage.libs.ntl.ntl_mat_ZZ_p', sources = ["sage/libs/ntl/ntl_mat_ZZ_p.pyx"], libraries = ["ntl", "gmp", "m"], language='c++'), ``` it is prefered to put them in the...

comment:18 Is there a reason why you add the prefix `mat_ZZ_p_` to all function names? Cython perfectly supports function overloading (in C++). Since it is done that way in all...

comment:19 Don't put the declaration and implementation of `ntl_mat_ZZ_p` inside `sage/libs`. The repo `sage/libs` is intended for library declarations. All code related to matrices should go in `sage/matrix/`.

comment:20 And many remarks from 14 months ago have not been adressed.

comment:1 Before proceeding, I would like to understand what package developers and package users would gain by declaring Python packages as sage optional packages. For now, I would only consider...

Description changed: ``````diff --- +++ @@ -16,4 +16,5 @@ Tickets: - #31176 Add packages from 3-manifolds / computop +- #31223 sage-train-track ``````

Description changed: ``````diff --- +++ @@ -17,4 +17,5 @@ Tickets: - #31176 Add packages from 3-manifolds / computop - #31223 sage-train-track +- #31224 surface-dynamics ``````

Description changed: ``````diff --- +++ @@ -19,4 +19,4 @@ - #31223 sage-train-track - #31224 surface-dynamics - #31235 sage-numerical-interactive-mip, cutgeneratingfunctionology - +- #31237 slabbe ``````

Description changed: ``````diff --- +++ @@ -20,3 +20,4 @@ - #31224 surface-dynamics - #31235 sage-numerical-interactive-mip, cutgeneratingfunctionology - #31237 slabbe +- #31328 admcycles ``````