Vidar Tonaas Fauske

Results 589 comments of Vidar Tonaas Fauske

Would you consider this a duplicate of https://github.com/jupyter/nbdime/issues/529, or is it different?

nbidme looks in the directories output by `jupyter --paths` ("config" section). If you want it to only happen for certain folders/files in a git repository then it should be possible...

Ah, you are using the lab/nb extension. I agree that it might be a bit ambiguous what the working directory refers to in those cases. Any suggestions for improvement to...

This makes sense, and it should be possible with a reasonably small amount of work. It would need to not ignore metadata during the actual diffing process, and instead only...

Since the output is passed through git, I'm not sure if this is something that can be reliably done or not. If someone has time to test that would be...

Hi! If you wanted to make a git filter based on nbdime, I think the simplest logic would be to: - Configure filtering of diff using these functions: https://github.com/jupyter/nbdime/blob/1f864d298b0c6c987316a8cd92fca820ea1d8757/nbdime/diffing/notebooks.py#L544-L589 -...

It is theoretically possible, but someone would have to integrate nbdime with the Jupyterlab UI to allow selecting the files to diff, and with the Jupyter contents manager so that...

Note that nbdime has a stub for adding this logic here: https://github.com/jupyter/nbdime/blob/a9435d5a76154f451aa9b2e9cc6f403aa4a78f42/packages/labextension/src/plugin.ts#L220-L223

The [git docs says](https://git-scm.com/docs/git#Documentation/git.txt-codeGITEXTERNALDIFFcode) that the diff driver is supposed to be called with the following arguments: ``` path old-file old-hex old-mode new-file new-hex new-mode ``` I wonder if this...