SAM icon indicating copy to clipboard operation
SAM copied to clipboard

Fix wrong data

Open AlexGuo1998 opened this issue 5 years ago • 1 comments

82 ('R') should be 72 ('H') here. Maybe some mistakes in refactoring: https://github.com/vidarh/SAM/commit/5a4b88b387316309ef7636fc332b5e66906d8694#diff-8e2c3c7e3979240badeac46c09c0dfd8R269 (Original https://github.com/s-macke/SAM/blob/bcf92b5c693cbaf25e26c17c1c1b0589b3647489/src/reciter.c#L492-L493)

BTW, I'm trying to totally re-write reciter in C.

AlexGuo1998 avatar Apr 11 '19 05:04 AlexGuo1998

Hm... Some more strange things here.

It seems r is always 1. A bug in original program? https://github.com/vidarh/SAM/blob/b735dbd320239e2f5fbff15a29388f6513c2f218/src/reciter.c#L212-L216

if Code37055(mem58+1, 4) == 0 is true, A would be chars other than D J L N R S T Z. But 72='H', 84='T', 67='C', 83='S'... https://github.com/vidarh/SAM/blob/b735dbd320239e2f5fbff15a29388f6513c2f218/src/reciter.c#L281-L287

AlexGuo1998 avatar Apr 11 '19 05:04 AlexGuo1998