pikaraoke icon indicating copy to clipboard operation
pikaraoke copied to clipboard

Feature Request: Volume Slide Bar or output level indicator

Open Romeo1984 opened this issue 2 years ago • 2 comments

Would be nice to have some way of knowing where the volume is set under the Hone Screen Player Control, especially when everybody has access to the player control.

Romeo1984 avatar Jan 18 '22 03:01 Romeo1984

@Romeo1984 , I have implemented this feature and posted a pull-request, please look at my fork at https://github.com/xuancong84/pikaraoke Take note that VLC volume level can well exceed 100%, (e.g., using VLC HTTP API, it can reach even 800% by directly multiplying the input waveform by 8 (this will cause aggressive aliasing with PCM values exceeding integer limit clamped at int max/min), and there is no limit to the volume level. Thus, it is not appropriate for me to put a slider to limit volume into the range from 0-100 or 0-200. There are other more useful features such as pitch-shift without restart from beginning, that we can improve on top of it.

xuancong84 avatar Jan 29 '22 07:01 xuancong84

Thank you! Yes, I noticed that I have to strike a careful balance between having the native pi 3.5 audio output loud enough for the downstream audio device to process, but have the pikaraoke volume low enough not to overdrive the speakers and cause distortion. This is the root of my request - so I can visually see where the pikaraoke app is set to.

Romeo1984 avatar Jan 30 '22 19:01 Romeo1984