pytorch-template icon indicating copy to clipboard operation
pytorch-template copied to clipboard

Minor fixes to `Trainer` and `BaseTrainer` Initializers

Open itsnamgyu opened this issue 4 years ago • 0 comments

  • self.metric_ftns was previously assigned in BaseTrainer.__init__, but there are no uses of self.metric_ftns in BaseTrainer. What's more, it seems that tracking metrics is not a responsibility of BaseTrainer. Thus, this has been removed from BaseTrainer and self.metric_ftns is now assigned in Trainer.__init__.
  • self.config was previously assigned in both BaseTrainer.__init__ and Trainer.__init__. It has been removed from Trainer.

itsnamgyu avatar May 25 '21 16:05 itsnamgyu