neuralqa icon indicating copy to clipboard operation
neuralqa copied to clipboard
verified publisher icon victordibia

Pytorch in requirements?

Open dconathan opened this issue 5 years ago • 3 comments

Both torch and torchvision are in requirements.txt and setup.py but they don't seem to be used anywhere. Any particular reason you have both torch and tensorflow in requirements?

dconathan avatar Sep 21 '20 16:09 dconathan

Hi @dconathan

I recall this being a requirement to load/convert HF models that do not have TF weights.
I am happy to get your thoughts on ways to completely sidestep pytorch/torchvision (as it makes the install really heavy ). I'll investigate a bit more .. let me know if you have any additional ideas.

victordibia avatar Sep 21 '20 17:09 victordibia

Ah that makes sense. Are you open to pytorch-only backend and eliminating tensorflow as a dependency?

dconathan avatar Sep 21 '20 18:09 dconathan

At this point, that seems like a good way to simply things. I'll take a pass this weekend, articulate out an issue and post an update. Given that the library is not more focused on usability/visual interface, it probably does not matter much if its pt or tf underneath.

victordibia avatar Sep 22 '20 03:09 victordibia