ngProgress icon indicating copy to clipboard operation
ngProgress copied to clipboard

Styling must not belong to JavaScript

Open slavafomin opened this issue 11 years ago • 4 comments

Presentation must be separate from business logic.

I suggest to deprecate methods like height and color and replace them with CSS styling completely.

Right now I can't use my SCSS styles and variables to style progress bar and this is really wrong.

slavafomin avatar Apr 09 '14 19:04 slavafomin

@slavafomin Agreed.

daviesgeek avatar Apr 16 '14 21:04 daviesgeek

+1

dasois avatar May 24 '14 08:05 dasois

I'll be submitting a pull request for this later. It seems to be as simple as removing the hard coded css values in the provider in order for overriding the css to actually work. The height and color functions will still be there but won't be necessary to use.

JDWardle avatar Jun 26 '14 23:06 JDWardle

Yeah, a solution where styles isn't hardcoded but still possible to change color via JavaScript would be acceptable.

victorb avatar Sep 26 '14 14:09 victorb