ngProgress
ngProgress copied to clipboard
Styling must not belong to JavaScript
Presentation must be separate from business logic.
I suggest to deprecate methods like height and color and replace them with CSS styling completely.
Right now I can't use my SCSS styles and variables to style progress bar and this is really wrong.
@slavafomin Agreed.
+1
I'll be submitting a pull request for this later. It seems to be as simple as removing the hard coded css values in the provider in order for overriding the css to actually work. The height and color functions will still be there but won't be necessary to use.
Yeah, a solution where styles isn't hardcoded but still possible to change color via JavaScript would be acceptable.