Victor Torres

Results 27 comments of Victor Torres

If we're doing this, we need to add documentation specifying that the use case intended is with a very short list of allowed IPs. It's not suited for large sets...

> @victor-torres If every thing is all right here then can we merge this pull request? I'm just waiting for @italorossi's input regarding moving the verification logic to another method....

The contrast may be obvious for you, but for some people with special disabilities and some underpowered devices and their poor screens, the story may be different. Anyway, this is...

web-poet works independently of Scrapy, but you can use [scrapy-poet](https://github.com/scrapinghub/scrapy-poet) to integrate web-poet into Scrapy projects. scrapy-poet offers an injector middleware that builds and injects dependencies. It has some ["Scrapy-provided"...

As I've said in #11, the example I gave you is wrong in two ways: - it should be `scrapy_response: Response` instead of `scrapy_response = Response` (this is why you're...

We've discussed this issue today and @ivanprado was able to spot the problem with my snippet: it's missing an `__init__` method or an `attrib.s` decoration, like the `ItemWebPage` itself. The...

I believe we need to decide if we are keeping features like JSON Schema Validation and Slack Notification on the project's core (#88, for example). Depending on what's decided, we...