viciscat

Results 59 comments of viciscat

> Unfortunately appears to be a bit buggy. these should be fixed

> > I think it would probably be better as a just some text you can freely move around since I don't know if speed is fit for a bar....

> Reason I'm reporting here is that biomes are completely different between version and some of these issues cannot be fixed without mods. Items and countless other things are also...

yeah biome data is indeed less precise, then biome blending does it's things. But that's still an hypixel issue in my humble imho opinion. Depends on the other devs' opinions.

sweet! Should the methods be added in the `Map` interfaces or `Maps` (with an s) classes

Not sure honestly... I'm not the data structure champion. Maybe an array implementation? I heard that it's good when you just access and don't write in it. Did not do...

What if it's more than 10 entries? HashMap?

Or I could just return an ArrayMap / OpenHashMap in an unmodifiable wrapper depending on the number of entries. That would be the easiest to write.

I'm guessing tests would be wanted? I don't see any test classes for the Map interfaces. Do I create a new one? Do I do it like `Primitive2PrimitiveMapTest` and `Primitive2ObjectMapTest`?

Some `MapTest`s have mentions to Maps methods. But they are present to create singletons, not actually tested. `MapGenericTest` uses and tests `Maps` stuff tho.