Victor Berchet

feat: allow setting cursor to null

4

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure...

Do not clutter the logs with warnings in prod environment

7

The [following code](https://github.com/googleapis/nodejs-datastore/blob/cd59c718ebe6711603b08b3ba2677e5a984bc7e3/src/query.ts#LL198C1-L200C34) ```js const companyQuery = query .filter('name', 'Google') .filter('size', '

[BUG] hide/show advanced markers does not work

9

#### Environment details I am using the beta channel of Google Maps and `@googlemaps/markerclusterer` at 2.1.3 I am adding a bunch of marker to a clusterer: ```js for (const launch...

Use a Set of markers instead of an array

1

The clusterer uses an array of markers: https://github.com/googlemaps/js-markerclusterer/blob/9476b3a62399fd124c92ed74faae6943cf573ea4/src/markerclusterer.ts#L33 This is inefficient has the lib often scans the whole list (and by definition the list is big when you use the...

As of today the stats are computed eagerly as they are constructed: https://github.com/googlemaps/js-markerclusterer/blob/e8eecf49b1d1f59579f3316c705f2c131b796560/src/renderer.ts#L35-L50 That's wasted CPU cycles when the stats are not required (i.e. with a custom renderer). We should...

[FR] Compile this library in strict mode

1

There are a few typing issues in the code i.e. https://github.com/googlemaps/js-markerclusterer/blob/e8eecf49b1d1f59579f3316c705f2c131b796560/src/algorithms/grid.ts#LL49C1-L61C4 `this.state = { zoom: null };` is not compatible with `protected state: { zoom: number };` This lib should...

It would be nice to update the dependencies of the lib. That is switching to rollup 3, updating jest, ... I use [Nx](https://nx.dev/) for my projects and it is very...

[FR] Add starter code to the issue template

1

It would be super convenient to add some starter code to the issue template (i.e. jsfiddle) It would make it much easier to create a repro to attach with bugs

Isn't keys() type wrong ?

2

[keys() type](https://github.com/nullcc/ts-interface-keys-transformer/blob/master/index.ts) is `export declare function keys(): Array;` but it seems like it should return `{name: string, ...}[]` ?

[HttpFoundation] Session handlers should use a lock

45

The following [session handlers](https://github.com/symfony/symfony/tree/master/src/Symfony/Component/HttpFoundation/Session/Storage/Handler): - MemcachedSessionHandler - MemcacheSessionHandler - MongoDbSessionHandler - PdoSessionHandler done do not use a lock to serialize access to the session data. This might result in a...