Victor Berchet

It looks the the (undocumented feature) I was looking for, thanks! I'll give it a try.

`find_additional_modules = true` seems to work - I am not exactly sure how. - It looks like we have "implicit" rules which will always add [`.html`, `.txt`, ...](find_additional_modules = true)...

Pete has documented `find_additional_modules` in https://github.com/cloudflare/cloudflare-docs/pull/17524 (mayeb we should add the implicit rules for JS files).

I'd like to propose to drop `find_additional_modules` for wrangler v4. **Current documentation for `find_additional_modules`:** - https://developers.cloudflare.com/workers/wrangler/configuration/#find-additional-modules - https://developers.cloudflare.com/workers/wrangler/bundling/#find-additional-modules - https://github.com/cloudflare/workers-sdk/blob/main/packages/wrangler/CHANGELOG.md#minor-changes-79 **(Approximate) behavior of `find_additional_modules`:** You can defined [`rules`](https://developers.cloudflare.com/workers/wrangler/configuration/#:~:text=to%20triggers.-,rules,-Rule) in your...

> When `no_bundle` is false these rules still play a part: Only if `find_additional_modules` is set to `true`, right? (That's what I meant by "When no_bundle is false (the default...

I really can not make sense of `find_additional_modules`, may be it's related to the bug you mentioned in https://github.com/cloudflare/workers-sdk/issues/6944#issuecomment-2498422487. I'll look at in the morning tomorrow :)

> Surely you should put just the env vars in that file. If you want other types, put them in your library! Yes, you can do that by passing args...

The root cause seem to be in `iconv-lite`, see the generated code: ```ts var require_lib = __commonJS({ "node_modules/body-parser/node_modules/iconv-lite/lib/index.js"(exports2, module2) { // ... var nodeVer = typeof process !== "undefined" &&...

Looks like an issue with `node_modules/body-parser/node_modules/iconv-lite/package.json`: If you remove the following code: ``` "browser": { "./lib/extend-node": false, "./lib/streams": false }, ``` Then it will work. Sorry for the lack of...

@petebacondarwin thanks for the headsup. Let's close this issue for now and re-consider if someone comments.