Victor LEFEBVRE
Victor LEFEBVRE
Ok no problem 👌 I don't have any other fallible sanitization function in mind at the moment, if I find some I'll tell you
You're right, I was too focused on doing `#[auto_enum(Into)]` instead of `#[auto_enum(Into)]` and making the impl generic. I tried that approach with great success regarding codegen. but no success regarding...
Still need to update the changelog and see if i missed some docs but the implementation looks good to me let me know if it looks good too you too...
Out of curiosity I tried a `From` implementation ```rs fn a(x: u8) -> impl Into { enum __Enum6219237852123227426< __Variant0, __Variant1, __Variant2, __Variant3, > { __Variant0(__Variant0), __Variant1(__Variant1), __Variant2(__Variant2), __Variant3(__Variant3), } impl...
Hello @taiki-e I rebased the PR, I think it's ready to be reviewed and merged 👍
We good 👍 @taiki-e
Sorry about that, took care of the other comments but managed to forgot that one. Test is written, passes when loaded from the ide without any issue but I can't...
~~The test seems to happen twice, once "Into" gets parsed but then another one only parses "Into" resulting in an error, I don't get why that second occurence appears~~ ~~Seems...
Ok, I think I got it, I encourage you to double/triple check the `type_analysis` changes as I'm really not sure I understood its inner workings correctly
Note: this issue could be concerned by #877 and other discussions on `bitflags` v1 vs v2