apollo-phoenix-websocket icon indicating copy to clipboard operation
apollo-phoenix-websocket copied to clipboard

URI option required but not used when socket is provided

Open mgwidmann opened this issue 6 years ago • 2 comments

In the following code, the uri option is required to be passed in, even though its not used since the socket parameter is provided. I've used this to supply my own socket connection parameters.

createNetworkInterface({
    uri: '/this-does-not-matter',
    Socket: () => { return socket; }
  });

mgwidmann avatar Oct 09 '17 13:10 mgwidmann

Oh right, thanks for reporting this, are you interested in sending an small PR ?

vic avatar Oct 24 '17 22:10 vic

Yeah I can take a look... All you'd want is just to not have to pass it in then right? Should be just something like { Socket: () => { return socket; } } passed in

mgwidmann avatar Nov 06 '17 04:11 mgwidmann