vibe.d icon indicating copy to clipboard operation
vibe.d copied to clipboard

meta/codegen.d: Fix getSymbols for dlang/dmd#11320

Open ntrel opened this issue 4 years ago • 3 comments

This fixes #2455. Instead of changing the assert I just made getSymbols continue dropping qualifiers, because that will work with both existing and future dmd.

See https://github.com/dlang/dmd/pull/11320.

ntrel avatar Jul 10 '20 08:07 ntrel

A comment would be nice

Geod24 avatar Jul 10 '20 09:07 Geod24

@geod24 I've edited the description and added links, hope that's ok

ntrel avatar Jul 10 '20 11:07 ntrel

looking at the usage (figure out which imports need to happen to include these symbols), I think this change is correct in terms of what this thing is meant to do. I would suggest a document comment that clarifies that attributes will be stripped from types.

schveiguy avatar Jul 10 '20 17:07 schveiguy