vSwarm icon indicating copy to clipboard operation
vSwarm copied to clipboard

Refactor python storage module to use class

Open MBaczun opened this issue 4 years ago • 8 comments

Refactors the python storage module to use a class.

Updates the module unit test. Updated video analytics, tuning halving, stacking training.

Signed-off-by: Michal Baczun [email protected]

MBaczun avatar Aug 27 '21 11:08 MBaczun

what's the status of this one?

ustiugov avatar Sep 17 '21 17:09 ustiugov

@MBaczun how ready is that?

ustiugov avatar Sep 20 '21 16:09 ustiugov

The module is refactored and the benchmarks listed in the description have been updated.

I think this still needs to have XDT support in the module, this is something I spoke about with shyam, but if not then it's probably safe to merge after a rebase.

Also I am not certain if video analytics, tuning halving, and stacking training are the only benchmarks that use this module because I added a few more benchmarks since working on this. If all of the CI works then it should be fine though!

Long-term, once XDT is supported, I think all of the benchmarks should be using this module.

MBaczun avatar Sep 20 '21 17:09 MBaczun

@shyamjesal what is your view on this? what would you suggest?

ustiugov avatar Sep 21 '21 09:09 ustiugov

I can add XDT support for this. This would not take much time.

shyamjesal avatar Sep 21 '21 12:09 shyamjesal

Ok, thanks! Shyam, please take a lead on this

ustiugov avatar Sep 21 '21 12:09 ustiugov

@MBaczun reopen if still relevant

dhschall avatar Nov 07 '23 13:11 dhschall

this is definitely useful functionality.... let's keep it open

ustiugov avatar Nov 11 '23 05:11 ustiugov