victor felder

Results 28 comments of victor felder

IMO remark-mermaid code structure isn't that bad. It does spawn a child process but that's to an npm package that we could depend on, not to a completely foreign binary....

> @annphan Nope. I ended up doing it the old-fashioned way: I stripped the top level element from the geojson files, so that they were just rootless feature collections, and...

I don't understand the idea or the goal, perhaps an example would help?

> However, I think implementations should be _allowed_ to throw an error when the user tries to manipulate. It could be confusing if users try to do `triple.subject = otherSubject`...

Unfortunately it's an issue in Kramdown, see https://github.com/gettalong/kramdown/issues/431 / https://github.com/jekyll/jekyll/issues/2818 / https://stackoverflow.com/questions/23751917/how-do-you-disable-tables-in-kramdown and it seems to be a wontfix. Creating a remark-lint plugin for this would make sense IMO.

Good work! I think the naming of this package is a bit too broad, making it more explicit (and prefixing it with `remark-lint-`) would be much better for the remark-lint...

Your visit within a visit is fine: visiting every text node in every link and nothing else. 👍 That way it will detect pipes in any child, eg. `[*This is*...

I'm having the same issue.

@ilianiliev please submit a better patch.